Updating misleading build target documentation#3915
Merged
Conversation
tcoz
reviewed
Jan 9, 2017
tcoz
left a comment
tcoz
left a comment
There was a problem hiding this comment.
From the docs it seems there's all these options:
ng build --prod
(seems preferred)
ng build -prod
(works, albeit frowned upon)
ng build --target -prod
(what this doc says)
If that's correct, maybe that could be made clearer elsewhere, otherwise this fixes the --target arg doc.
Contributor
Author
|
@tcoz Thank you for your fast reply and feedback, I've made some changes to further clarify this hopefully this makes it more clear. |
RicardoVaranda
changed the title
Contributor
|
LGTM. Thanks! |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old build documentation stated that prod was a valid target command which is incorrect.
The working and valid production commands are:
--prod
-prod
Not:
prod